The calculated percentage was being calculated for the entire set not for individual software. I think I have updated list_viewdef_statistic_keys.php correctly to have the percentage calculate for the individual software. So basically you can now see that if you have 3 keys for Microsoft office but they are used in the counts of 67 / 34 / 12 total machines installs this would translate to 59.29%, 30.08%, and 10.61%. This was not possible before. They were also being sorted by the key name and not the software name. I find it more beneficial to sort by software name and show the grouping of all the keys together for that software. I more often look at this to find how I am doing on consolidation or something to that effect. I don't know if I would ever really look up this list by key....
But if both need to be kept perhaps this file should be renamed with a 2 or some differentiating item in the name so we can have both reports?
I have also updated the auditing script to include more software like upgraded (newer) versions of autocad, inventor, solidworks, mathcad (and trying to find any software that has a serial number at our work) and I think that is about it. I will post my upgrades to audit.vbs in another post.
[code]<?php
$query_array=array("headline"=>__("Statistic for Software Keys"), "sql"=>" SELECT DISTINCT ms_keys_cd_key, COUNT(ms_keys_cd_key) AS count_item, ROUND( 100 * count(k1.ms_keys_cd_key) / ( select count(k2.ms_keys_name) from ms_keys k2, system s2 where k2.ms_keys_name = k1.ms_keys_name AND k2.ms_keys_uuid = s2.system_uuid AND k2.ms_keys_timestamp = s2.system_timestamp) , $round_to_decimal_places) AS percentage,ms_keys_name FROM ms_keys k1, system s1 WHERE ms_keys_uuid = system_uuid AND ms_keys_timestamp = system_timestamp AND ms_keys_cd_key != '' GROUP BY ms_keys_name,ms_keys_cd_key ", "sort"=>"ms_keys_name", "dir"=>"ASC", "fields"=>array("10"=>array("name"=>"ms_keys_cd_key", "head"=>__("CD Key"), "show"=>"y", "link"=>"n", ), "20"=>array("name"=>"ms_keys_name", "head"=>__("Name"), "show"=>"y", "link"=>"n", ), "30"=>array("name"=>"count_item", "head"=>__("Count"), "show"=>"y", "link"=>"n", "search"=>"n", ), "40"=>array("name"=>"percentage", "head"=>__("Percentage"), "show"=>"y", "link"=>"n", "search"=>"n", ), ), ); ?>[/code]
_________________ Matt Feider Internal: OS : Hardy Heron Ubuntu, apache, VM'ed Auditing: 172 machines LDAP: Active Directory
External: OS : Don't know as it is hosted Auditing: 826 machines LDAP: AD, but not hooked up as it is external
|