Registrations to Open-AudIT forums are now closed. To ask any new questions please visit Opmantek Community Questions.

Open-AudIT

What's on your network?
It is currently Fri Mar 29, 2024 11:01 am

All times are UTC + 10 hours




Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 42 posts ]  Go to page Previous  1, 2, 3  Next
Author Message
 Post subject: Re: Home page update
PostPosted: Tue Apr 15, 2008 12:05 am 
Offline
Contributor

Joined: Fri Jul 28, 2006 6:30 am
Posts: 157
Location: London
Ok, here's my revised version hopefully incorporating all recent code revisions that have come through SVN.
[url]http://www.npbconsultants.com/public/openauditupdate.zip[/url]
We don't need includenpb.php any more because I've moved the code into default.css.
Also fixed the divide by zero problem.
I've broken index_data.php into smaller functions than before to make it easier to understand and manage in future.

Cheers, Nick.

_________________
Cheers, Nick.

[size=85]OA Server: Windows Server 2003 / Apache 2
Auditing: 1600 Workstations, 200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows Vista
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Tue Apr 15, 2008 2:13 am 
Offline
Open-AudIT Fellow

Joined: Thu May 17, 2007 5:47 pm
Posts: 568
Location: Italy
Sorry, still same notices (Undefined variable) regarding bgcolor, bg1 and bg2 in index_data.php, for every instance of
[code]
$bgcolor = change_row_color($bgcolor,$bg1,$bg2);
[/code]

_________________
Edoardo


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Tue Apr 15, 2008 3:02 am 
Offline
Contributor

Joined: Fri Jul 28, 2006 6:30 am
Posts: 157
Location: London
Hmm. What version of PHP are you running? I can't seem to reproduce the error here.
Can you add:
[code]include "include_col_scheme.php";[/code]
At line 11 of index_data.php. I suspect that will fix it but can't confirm it until I can reproduce what you're getting.

Cheers, Nick.

_________________
Cheers, Nick.

[size=85]OA Server: Windows Server 2003 / Apache 2
Auditing: 1600 Workstations, 200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows Vista
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Tue Apr 15, 2008 3:08 am 
Offline
Newbie
User avatar

Joined: Wed Apr 02, 2008 8:45 am
Posts: 21
any idea as to when this update will be in the svn I have been watching the forum threads daily in anticipation to this change. Seems like this will be a great feature change that will greatly assist our systems.

thank you

Jon

_________________
Jon
The Tech Guy
http://www.thetechguyusa.com


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Tue Apr 15, 2008 4:03 am 
Offline
Open-AudIT Fellow

Joined: Thu May 17, 2007 5:47 pm
Posts: 568
Location: Italy
[quote="NickBrown"]Hmm. What version of PHP are you running? I can't seem to reproduce the error here.
Can you add:
[code]include "include_col_scheme.php";[/code]
At line 11 of index_data.php. I suspect that will fix it but can't confirm it until I can reproduce what you're getting.

Added, but same result. I run PHP 5.2.1 on IIS 6 (SP2).
My php.ini error conf:
[code]
error_reporting = E_ALL
log_errors = On
error_log = "MyError.log"
[/code]
with MyError.log writable by IIS. To show same errors on screen
[code]
display_errors = On
[/code]
Hope it helps to show those notices (another PHP Notice I forgot to mention: Undefined variable: vnc_type) in index_data.php

_________________
Edoardo


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Tue Apr 15, 2008 6:57 am 
Offline
Contributor

Joined: Fri Jul 28, 2006 6:30 am
Posts: 157
Location: London
Ok, modifying PHP.INI error reporting enabled me to reproduce the errors, which I've fixed. The updated files are in [url]http://www.npbconsultants.com/public/openauditupdate.zip[/url]

Copule of things:
- There is a bug in the current SVN index.php. There are several lines that read something like:
[code]<tr style=\"bgcolor:" . $bgcolor . ";\">[/code]
But bgcolor is a (deprecated) HTML attribute, not a CSS property. The correct property should be "background-color". I've fixed this in my version.

- The change_row_color() function. It seems to me that the last two arguments would stay the same for the duration of code execution. It therefore seems superflouous to have them as function arguments. Couldn't we just add:
[code]include_once "include_col_scheme.php";[/code]
to the top of include_functions.php and drop these from the argument list?

Cheers, Nick.

_________________
Cheers, Nick.

[size=85]OA Server: Windows Server 2003 / Apache 2
Auditing: 1600 Workstations, 200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows Vista
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Tue Apr 15, 2008 5:28 pm 
Offline
Open-AudIT Fellow

Joined: Thu May 17, 2007 5:47 pm
Posts: 568
Location: Italy
Now It's OK for me, thank you.

_________________
Edoardo


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Tue Apr 15, 2008 9:11 pm 
Offline
Moderator
User avatar

Joined: Tue Jan 25, 2005 3:09 am
Posts: 2140
Location: Scotland
That looks a lot better, I'll add this back in if nobody objects by the end of today. :wink:

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Tue Apr 15, 2008 9:14 pm 
Offline
Moderator
User avatar

Joined: Tue Jan 25, 2005 3:09 am
Posts: 2140
Location: Scotland
[quote="NickBrown"]
Copule of things:
- There is a bug in the current SVN index.php. There are several lines that read something like:
[code]<tr style=\"bgcolor:" . $bgcolor . ";\">[/code]
But bgcolor is a (deprecated) HTML attribute, not a CSS property. The correct property should be "background-color". I've fixed this in my version.


- The change_row_color() function. It seems to me that the last two arguments would stay the same for the duration of code execution. It therefore seems superflouous to have them as function arguments. Couldn't we just add:
[code]include_once "include_col_scheme.php";[/code]
to the top of include_functions.php and drop these from the argument list?

Cheers, Nick.


Sounds like a plan, I don't think this will cause a problem, but try it and see.

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Wed Apr 16, 2008 8:31 pm 
Offline
Contributor

Joined: Fri Jul 28, 2006 6:30 am
Posts: 157
Location: London
See if you prefer this "please wait" graphic instead (best viewed in-situ).

[attachment=0] hourglass-busy.gif
hourglass-busy.gif [ 20.9 KiB | Viewed 7417 times ]

I think I prefer it (the hourglass metaphor is a bit 80's now).

Cheers, Nick.

_________________
Cheers, Nick.

[size=85]OA Server: Windows Server 2003 / Apache 2
Auditing: 1600 Workstations, 200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows Vista
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Wed Apr 16, 2008 11:56 pm 
Offline
Moderator
User avatar

Joined: Tue Jan 25, 2005 3:09 am
Posts: 2140
Location: Scotland
Yes, much prefer that, but is it GPL?

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Thu Apr 17, 2008 12:03 am 
Offline
Contributor

Joined: Fri Jul 28, 2006 6:30 am
Posts: 157
Location: London
[quote="A_Hull"]Yes, much prefer that, but is it GPL?


I'll have to check where I got it from. I believe it was from a graphics tutorial explaining how to create it ...

Cheers, Nick.

_________________
Cheers, Nick.

[size=85]OA Server: Windows Server 2003 / Apache 2
Auditing: 1600 Workstations, 200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows Vista
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Thu Apr 17, 2008 12:35 am 
Offline
Moderator
User avatar

Joined: Tue Jan 25, 2005 3:09 am
Posts: 2140
Location: Scotland
If not, can we find something that is, (and looks good of course).
I thought of this.... :twisted:
[attachment=0] breaktux.gif
breaktux.gif [ 10.8 KiB | Viewed 7357 times ]

..Perhaps not..

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Fri Apr 18, 2008 12:56 am 
Offline
Contributor

Joined: Fri Jul 28, 2006 6:30 am
Posts: 157
Location: London
I've managed to knock this together myself. It's not quite perfect, but looks OK in-situ IMO?

Cheers, Nick.

[attachment=0] hourglass-busy.gif
hourglass-busy.gif [ 24.88 KiB | Viewed 7352 times ]

_________________
Cheers, Nick.

[size=85]OA Server: Windows Server 2003 / Apache 2
Auditing: 1600 Workstations, 200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows Vista
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Home page update
PostPosted: Fri Apr 18, 2008 2:24 am 
Offline
Moderator
User avatar

Joined: Tue Jan 25, 2005 3:09 am
Posts: 2140
Location: Scotland
Looks good to me, not as entertaining as the Tux perhaps, but better than my offering...[attachment=0] hourglass-busy.gif
hourglass-busy.gif [ 13.96 KiB | Viewed 7341 times ]
...Oh well, dont give up the day job Andrew.... :roll:

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 42 posts ]  Go to page Previous  1, 2, 3  Next

All times are UTC + 10 hours


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group