Registrations to Open-AudIT forums are now closed. To ask any new questions please visit Opmantek Community Questions.

Open-AudIT

What's on your network?
It is currently Fri Mar 29, 2024 1:55 am

All times are UTC + 10 hours




Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 3 posts ] 
Author Message
 Post subject: Bug in ip_trans_to
PostPosted: Sat Jan 03, 2009 12:24 am 
There is a bug in the ip_trans_ip function in include_functions.php.
It takes a string and formats it to the database format, eg for 10.10.10.10 returns 010.010.010.010
If it is called with a number, eg 53000, the return is 000, which when called by search.php returns lots of spurious matches.
Solution is to change include_functions.php line 33 from
if (($ip <> "") AND (!(is_null($ip)))){

to

// check that the string is valid for an IP, it must have at least one . in it
if (($ip <> "") AND (!(is_null($ip))) AND (Substr_Count($ip,".")>0)){


Top
  
Reply with quote  
 Post subject: Re: Bug in ip_trans_to
PostPosted: Mon Jan 05, 2009 10:03 pm 
Offline
Moderator
User avatar

Joined: Tue Jan 25, 2005 3:09 am
Posts: 2140
Location: Scotland
Try it now. Thanks.
:D

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]


Top
 Profile  
Reply with quote  
 Post subject: Re: Bug in ip_trans_to
PostPosted: Fri Jan 30, 2009 11:58 pm 
Looks like this change was put in to the svn at line 13 rather than 33, ie to function ip_trans rather than ip_trans_to.
Should still be a sensible check, but needs to go in to ip_trans_to as well.


Top
  
Reply with quote  
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 3 posts ] 

All times are UTC + 10 hours


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group