Open-AudIT

Hi,

There is a bug in the upgrade.php script related to today's SVN update.

File: upgrade.php
Symptom: When you click on "New version found. Click here to upgrade!" you receive an error (PHP) like so:
[code]
Parse error: syntax error, unexpected T_STRING blah blah at Line 450
[/code]

Line 450 is not the problem. Problem is at line 448 which reads:

[code]
) ENGINE=MyISAM DEFAULT CHARSET=latin1;"
[/code]

should be:

[code]
) ENGINE=MyISAM DEFAULT CHARSET=latin1";
[/code]

Save and now you can run the upgrade.

Take care.

Jason

_________________
OA Deployment:
Windows 2003 with XAMPP install
80 Windows Servers
250 Windows workstations (mixed XP and 2000)
5 MACs
Multiple printers, switches, routers, firewalls, and other servers (ESX, AIX etc.)

I uploaded an earlier version of Nick's code, and then ran in to an issue updating it to the latest version, try it now.

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]

I´ve updated to the actual snv, but still get this error:

[quote]Upgrading to 08.10.08..............Query failed: CREATE TABLE `openaudit`.`log` ( `log_id` int(10) unsigned NOT NULL auto_increment, `log_timestamp` varchar(45) NOT NULL, `log_message` varchar(1024) NOT NULL, `log_severity` int(10) unsigned NOT NULL, `log_module` varchar(128) NOT NULL, `log_function` varchar(128) NOT NULL, PRIMARY KEY (`log_id`), ) ENGINE=MyISAM DEFAULT CHARSET=latin1
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') ENGINE=MyISAM DEFAULT CHARSET=latin1' at line 9

_________________
OA Deployment:
w2k3 R2 with XAMPP install
Windows Servers incl. VM
Windows workstations (XP and Vista, 7)
Multiple printers, switches, routers, firewalls
ADS 1HQ and 20 branches
-------------------
OAv2
w2k8 R2 with XAMPP install

Line 441 of upgrade.php is
[code]
DROP TABLE IF EXISTS `openaudit`.`log`;
CREATE TABLE `openaudit`.`log` (
[/code]
And should be ...
[code]
DROP TABLE IF EXISTS `log`;
CREATE TABLE `log` (
[/code]

See if changing that helps.

Cheers, Nick.

[quote="NickBrown"]Line 441 of upgrade.php is
[code]
DROP TABLE IF EXISTS `openaudit`.`log`;
CREATE TABLE `openaudit`.`log` (
[/code]
And should be ...
[code]
DROP TABLE IF EXISTS `log`;
CREATE TABLE `log` (
[/code]

See if changing that helps.

Cheers, Nick.

_________________
OA Deployment:
w2k3 R2 with XAMPP install
Windows Servers incl. VM
Windows workstations (XP and Vista, 7)
Multiple printers, switches, routers, firewalls
ADS 1HQ and 20 branches
-------------------
OAv2
w2k8 R2 with XAMPP install

Replace lines 441 to 450 of upgrade.php with this:

[code]
DROP TABLE IF EXISTS `log`;
CREATE TABLE `log` (
`log_id` int(10) unsigned NOT NULL auto_increment,
`log_timestamp` varchar(45) NOT NULL,
`log_message` varchar(1024) NOT NULL,
`log_severity` int(10) unsigned NOT NULL,
`log_module` varchar(128) NOT NULL,
`log_function` varchar(128) NOT NULL,
PRIMARY KEY (`log_id`)
) ENGINE=MyISAM DEFAULT CHARSET=latin1;";
[/code]

Should do the trick.

Cheers, Nick.

_________________
Cheers, Nick.

[size=85]OA Server: Windows Server 2003 / Apache 2
Auditing: 1600 Workstations, 200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows Vista
LDAP: Active Directory[/size]

thanks

_________________
OA Deployment:
w2k3 R2 with XAMPP install
Windows Servers incl. VM
Windows workstations (XP and Vista, 7)
Multiple printers, switches, routers, firewalls
ADS 1HQ and 20 branches
-------------------
OAv2
w2k8 R2 with XAMPP install

No problem - this fix is in SVN 1070.

Cheers, Nick.

_________________
Cheers, Nick.

[size=85]OA Server: Windows Server 2003 / Apache 2
Auditing: 1600 Workstations, 200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows Vista
LDAP: Active Directory[/size]

[quote="NickBrown"]No problem - this fix is in SVN 1070.

Cheers, Nick.

_________________
Cheers, Nick.

[size=85]OA Server: Windows Server 2003 / Apache 2
Auditing: 1600 Workstations, 200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows Vista
LDAP: Active Directory[/size]

I just tried to update to the latest svn 1071 release and when performing the upgrade I get the following error.

[code]Upgrading to 08.10.09..Query failed: ALTER TABLE `software` ADD INDEX `Index4`(`software_name`)
BLOB/TEXT column 'software_name' used in key specification without a key length[/code]

Any advice?

What version of MySql are you running?

Cheers, Nick.

_________________
Cheers, Nick.

[size=85]OA Server: Windows Server 2003 / Apache 2
Auditing: 1600 Workstations, 200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows Vista
LDAP: Active Directory[/size]

I'm running 5.0.22

I think I found the problem, software_name was set to type TEXT. It appears that in a clean install it is now created as VARCHAR(256). So after backing up the table I changed the type to varchar(256). I was then able to perform the upgrade.

As a side note, the software view now FLY!.