Registrations to Open-AudIT forums are now closed. To ask any new questions please visit Opmantek Community Questions.

Open-AudIT

What's on your network?
It is currently Fri Apr 19, 2024 8:44 pm

View unanswered posts | View active topics


Board index » Bugs

All times are UTC + 10 hours




Forum locked This topic is locked, you cannot edit posts or make further replies.  Page 1 of 1
  [ 9 posts ] 
  Print view Previous topic | Next topic 
Author Message
jsingh
PostPosted: Tue Nov 25, 2008 1:19 am 
Offline
Contributor

Joined: Fri Sep 28, 2007 12:07 am
Posts: 189
Hi,

There is no need for lines 618-624.

Can we not replace this line of code which upsets a lot of my machines (primarily Windows 2000 systems) on the network from being audited.

It is best replace with:

[code]
if (IsConnectible(strComputer, "", "") OR (strComputer = ".")) then
[/code]

We have a function for WMI connectivity, why are we not using it there rather than relying on some logic that is a bit buggy.

Can we clear that up? I think it will address a lot of the issues some users are reporting with flaky/haphazard auditing.

Thanks

Jason

_________________
OA Deployment:
Windows 2003 with XAMPP install
80 Windows Servers
250 Windows workstations (mixed XP and 2000)
5 MACs
Multiple printers, switches, routers, firewalls, and other servers (ESX, AIX etc.)
Top
 Profile  
Reply with quote  
antorz
PostPosted: Thu Dec 04, 2008 2:28 am 
Offline
Newbie

Joined: Fri Nov 14, 2008 12:25 am
Posts: 12
Ive had the same problem and removed this line of code, anyone else?

Would like to post this to snv

_________________
OA Server: Windows Server 2003 / IIS6
Auditing: 1200 Servers
OS's: Windows XP / Windows 2000 / Windows 2003 Server / Windows 2008 Server
LDAP: Active Directory
Top
 Profile  
Reply with quote  
A_Hull
PostPosted: Thu Dec 04, 2008 8:28 pm 
Offline
Moderator
User avatar

Joined: Tue Jan 25, 2005 3:09 am
Posts: 2140
Location: Scotland
I take it you want this section of code to read as follows...

[code]
''''''''''''''''''''''''''''''''
' Double check WMI is working '
''''''''''''''''''''''''''''''''
if (IsConnectible(strComputer, "", "") OR (strComputer = ".")) then
'if ((UCase(strComputer) <> system_name) AND (strComputer <> ".") AND (strComputer <> full_system_name) AND (strComputer <> ns_ip) AND (strComputer <> system_ip)) then
email_failed = email_failed & strComputer & ", " & VBcrlf
ie = nothing
exit function
end if
[/code]
:?

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]
Top
 Profile  
Reply with quote  
jsingh
PostPosted: Thu Dec 04, 2008 10:17 pm 
Offline
Contributor

Joined: Fri Sep 28, 2007 12:07 am
Posts: 189
[quote="A_Hull"]I take it you want this section of code to read as follows...

[code]
''''''''''''''''''''''''''''''''
' Double check WMI is working '
''''''''''''''''''''''''''''''''
if (IsConnectible(strComputer, "", "") OR (strComputer = ".")) then
'if ((UCase(strComputer) <> system_name) AND (strComputer <> ".") AND (strComputer <> full_system_name) AND (strComputer <> ns_ip) AND (strComputer <> system_ip)) then
email_failed = email_failed & strComputer & ", " & VBcrlf
ie = nothing
exit function
end if
[/code]
:?



that is correct Andrew. What do you think? Personally i think it is overkill. Actually the add to email part or the check need to be moved in one place. Higher up in audit.vbs we do the "is WMI connectible". Why are we doing it twice?

Committing to SVN?

Will test and confirm.

Thanks

Jason

_________________
OA Deployment:
Windows 2003 with XAMPP install
80 Windows Servers
250 Windows workstations (mixed XP and 2000)
5 MACs
Multiple printers, switches, routers, firewalls, and other servers (ESX, AIX etc.)
Top
 Profile  
Reply with quote  
A_Hull
PostPosted: Thu Dec 04, 2008 11:38 pm 
Offline
Moderator
User avatar

Joined: Tue Jan 25, 2005 3:09 am
Posts: 2140
Location: Scotland
Not sure I follow the logic of this section, does anybody know what the purpose of this particular section is ?! :?

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]
Top
 Profile  
Reply with quote  
jsingh
PostPosted: Fri Dec 05, 2008 1:05 am 
Offline
Contributor

Joined: Fri Sep 28, 2007 12:07 am
Posts: 189
Agreed. I don't see the need either. If it is not needed let's at least comment it out and we can uncomment if needed later.

Jason

_________________
OA Deployment:
Windows 2003 with XAMPP install
80 Windows Servers
250 Windows workstations (mixed XP and 2000)
5 MACs
Multiple printers, switches, routers, firewalls, and other servers (ESX, AIX etc.)
Top
 Profile  
Reply with quote  
jsingh
PostPosted: Wed Dec 10, 2008 9:48 pm 
Offline
Contributor

Joined: Fri Sep 28, 2007 12:07 am
Posts: 189
Can we SVN please?

_________________
OA Deployment:
Windows 2003 with XAMPP install
80 Windows Servers
250 Windows workstations (mixed XP and 2000)
5 MACs
Multiple printers, switches, routers, firewalls, and other servers (ESX, AIX etc.)
Top
 Profile  
Reply with quote  
A_Hull
PostPosted: Thu Dec 11, 2008 12:11 am 
Offline
Moderator
User avatar

Joined: Tue Jan 25, 2005 3:09 am
Posts: 2140
Location: Scotland
Shall I just comment out the entire section? (Since we don't seem to need it, or for that matter can see what it is meant to do :? )

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]
Top
 Profile  
Reply with quote  
A_Hull
PostPosted: Thu Dec 11, 2008 12:17 am 
Offline
Moderator
User avatar

Joined: Tue Jan 25, 2005 3:09 am
Posts: 2140
Location: Scotland
Commit
W:\htdocs\OpenAuditSVN\scripts\audit.vbs
W:\htdocs\OpenAuditSVN\scripts\audit.vbs
At revision: 1098

Done!

_________________
Andrew

[size=85]OA Server: Windows XP/ XAMPP, Mandriva/Apache, Ubuntu
Auditing: 300+ Wstns, 20+ Srvrs, Thin clients, Linux boxes, Routers, etc
OS's: Windows XP , W2K Srvr, W2K3 Srvr, W2K8, Vista, Windows 7, Linuxes (and a Mac at home)
LDAP: Active Directory[/size]
Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  Page 1 of 1
  [ 9 posts ] 

Board index » Bugs

All times are UTC + 10 hours


Who is online

Users browsing this forum: No registered users and 2 guests

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group