Registrations to Open-AudIT forums are now closed. To ask any new questions please visit Opmantek Community Questions.

Open-AudIT

What's on your network?
It is currently Sat Apr 20, 2024 7:18 am

All times are UTC + 10 hours




Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 21 posts ]  Go to page Previous  1, 2
Author Message
 Post subject: Re: Performance
PostPosted: Wed Jan 07, 2009 5:51 am 
Apolgies for that, will make sure I latest version before amending it in future.
I am on a couple of days hols at the moment, but will see if I can do the same tweaks on this latest services query when I get back in the office.


Top
  
Reply with quote  
 Post subject: Re: Performance
PostPosted: Fri Jan 09, 2009 7:10 pm 
I have now modified the services query to use joins, performance is now much better, see attached file.
On the same topic searching for a common string such as 'microsoft' causes a memory exhausted error, presumably because of the number of rows returned, I will have a think and see if there is a way I can trap this and return a more sensible message, eg, "too many matches, data truncated"


Attachments:
search_php.zip [3.29 KiB]
Downloaded 296 times
Top
  
Reply with quote  
 Post subject: Re: Performance
PostPosted: Fri Jan 09, 2009 7:46 pm 
Offline
Open-AudIT Fellow

Joined: Thu May 17, 2007 5:47 pm
Posts: 568
Location: Italy
Using your last search.php, every service retrieved is duplicated...

_________________
Edoardo


Top
 Profile  
Reply with quote  
 Post subject: Re: Performance
PostPosted: Fri Jan 09, 2009 8:02 pm 
Sorry about that, I'm not seeing it on mine, however if you change line 246 from UNION ALL to UNION it should fix it.

ie from
$sql .= " UNION ALL ";
to
$sql .= " UNION ";
Make sure you have a space both before and after the word UNION.


Top
  
Reply with quote  
 Post subject: Re: Performance
PostPosted: Fri Jan 09, 2009 8:58 pm 
Offline
Open-AudIT Fellow

Joined: Thu May 17, 2007 5:47 pm
Posts: 568
Location: Italy
Thanks, added to SVN rev. 1115

_________________
Edoardo


Top
 Profile  
Reply with quote  
 Post subject: Re: Performance
PostPosted: Mon Jan 12, 2009 6:44 pm 
I also added the following indexes to the tables, so that we are now joining and searching on indexed fields.
alter table service add index (service_display_name);
alter table service add index (service_name);
alter table service_details add index (sd_display_name);
alter table service_details add index (sd_description);


Top
  
Reply with quote  
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 21 posts ]  Go to page Previous  1, 2

All times are UTC + 10 hours


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group