Open-AudIT

What's on your network?
It is currently Tue Jan 23, 2018 9:55 pm

All times are UTC + 10 hours




Post new topic Reply to topic  [ 10 posts ] 
Author Message
 Post subject: OAv2 alpha 6 - Feedback
PostPosted: Wed Dec 01, 2010 1:05 am 
Offline
Newbie

Joined: Thu May 05, 2005 11:50 pm
Posts: 14
Couple quick bugs:

1. When organization name is clicked in "index.php/admin_org/list_orgs", "404 Page Not Found" error is displayed. Should list all systems in that organization.
2. Report editing doesn't work in "index.php/admin_report/list_reports"
3. When organization data is added to the system, an empty field "Org Contact:" is displayed - but it doesn't exist in organization form.

Will do more testing tomorrow.


Top
 Profile  
Reply with quote  
PostPosted: Wed Dec 01, 2010 3:51 am 
Offline
Moderator

Joined: Fri Jul 20, 2007 8:27 am
Posts: 1228
Also found:

"Add organization" submit gives 404 as it redirects to "index.php/admin/list_orgs" rather than "index.php/admin_org/list_orgs"

Edit organization named "Test" to "Test 2" gives:
Code:
A PHP Error was encountered

Severity: Notice

Message: Undefined property: stdClass::$contact_id

Filename: models/m_oa_org.php

Line Number: 165
A Database Error Occurred

Error Number: 1064

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 9

UPDATE oa_org SET org_name = 'Test 2', org_parent_id = '0', contact_id = '', org_picture = '' WHERE org_id =


[UglyAmericanMode]Need to use the language stuff so I can translate Organisations to Organizations.[/UglyAmericanMode] :P


Top
 Profile  
Reply with quote  
PostPosted: Wed Dec 01, 2010 6:19 am 
Offline
Moderator

Joined: Fri Jul 20, 2007 8:27 am
Posts: 1228
Audit_domain.vbs has an extraneous wscript.quit at line 130.

The operating_system filter in audit_domain.vbs at line 104 only works when operating_system has a non-empty value. I'm not sure why the operating_system test is necessary. Changing the test to operating_system >= "" was my quick fix.

Request to allow "=" in audit_*.vbs command line switches.


Top
 Profile  
Reply with quote  
PostPosted: Thu Dec 02, 2010 12:10 am 
Offline
Newbie

Joined: Thu May 05, 2005 11:50 pm
Posts: 14
<select> controls work weird in system_display: when I click on a select control, it doesn't stay expanded and collapses immediately. When it switches from view to edit mode, value of the field doesn't get selected in select control, so you have to either select it again (which is tricky due to the first issue) or refresh the page to get it back in view mode.
Tested with Firefox 4b7 and IE8.


Top
 Profile  
Reply with quote  
PostPosted: Thu Dec 02, 2010 1:40 pm 
Offline
Site Admin
User avatar

Joined: Mon Jun 07, 2004 11:48 am
Posts: 1935
Location: Brisbane, Australia
Quote:
1. When organization name is clicked in "index.php/admin_org/list_orgs", "404 Page Not Found" error is displayed. Should list all systems in that organization.

Fixed.
Quote:
2. Report editing doesn't work in "index.php/admin_report/list_reports"

Now redirects to a "incomplete" page (as it is incomplete).
Quote:
3. When organization data is added to the system, an empty field "Org Contact:" is displayed - but it doesn't exist in organization form.

contact_id is a field in the oa_org table. It's meant to point to the oa_contacts table. i haven't coded the Contact CRUD stuff yet, so I have now commented out this field from displaying.

_________________
Support and Development hours available from Opmantek.
Please consider a purchase to help make Open-AudIT better for everyone.


Top
 Profile  
Reply with quote  
PostPosted: Thu Dec 02, 2010 1:41 pm 
Offline
Site Admin
User avatar

Joined: Mon Jun 07, 2004 11:48 am
Posts: 1935
Location: Brisbane, Australia
Quote:
"Add organization" submit gives 404 as it redirects to "index.php/admin/list_orgs" rather than "index.php/admin_org/list_orgs"

Fixed.
Quote:
Edit organization named "Test" to "Test 2" gives:

Fixed.

_________________
Support and Development hours available from Opmantek.
Please consider a purchase to help make Open-AudIT better for everyone.


Top
 Profile  
Reply with quote  
PostPosted: Thu Dec 02, 2010 1:44 pm 
Offline
Site Admin
User avatar

Joined: Mon Jun 07, 2004 11:48 am
Posts: 1935
Location: Brisbane, Australia
Quote:
Audit_domain.vbs has an extraneous wscript.quit at line 130.

Fixed.
Quote:
The operating_system filter in audit_domain.vbs at line 104 only works when operating_system has a non-empty value. I'm not sure why the operating_system test is necessary. Changing the test to operating_system >= "" was my quick fix.

Fixed.
Quote:
Request to allow "=" in audit_*.vbs command line switches.

Will check this out.

_________________
Support and Development hours available from Opmantek.
Please consider a purchase to help make Open-AudIT better for everyone.


Top
 Profile  
Reply with quote  
PostPosted: Thu Dec 02, 2010 1:49 pm 
Offline
Site Admin
User avatar

Joined: Mon Jun 07, 2004 11:48 am
Posts: 1935
Location: Brisbane, Australia
Quote:
<select> controls work weird in system_display: when I click on a select control, it doesn't stay expanded and collapses immediately. When it switches from view to edit mode, value of the field doesn't get selected in select control, so you have to either select it again (which is tricky due to the first issue) or refresh the page to get it back in view mode.
Tested with Firefox 4b7 and IE8.

Yeah - I see this too (FF 3.6.12 on Ubuntu 10.10).
When I click the <select> boxes, if I stay over the scroll bar, it works. If there is no scroll bar, I need to hold down the "click", and release on the item I want.
I have absolutely no idea why this is.
The code is very standard HTML.
If anyone wants to check this out, it would be most appreciated.

_________________
Support and Development hours available from Opmantek.
Please consider a purchase to help make Open-AudIT better for everyone.


Top
 Profile  
Reply with quote  
PostPosted: Thu Dec 02, 2010 5:44 pm 
Offline
Newbie

Joined: Thu May 05, 2005 11:50 pm
Posts: 14
Mark wrote:
Yeah - I see this too (FF 3.6.12 on Ubuntu 10.10).
When I click the <select> boxes, if I stay over the scroll bar, it works. If there is no scroll bar, I need to hold down the "click", and release on the item I want.
I have absolutely no idea why this is.
The code is very standard HTML.
If anyone wants to check this out, it would be most appreciated.


The problem is that <select> control is created inside <span>, which still has onclick event:
Code:
<span onclick="display_criticality();" style="color:blue;" id="man_criticality_select">
  <select onchange="send_select_criticality();" id="man_criticality">
    <option value=" ">Choose a criticality</option>
    <option value="critical">Critical</option>
    <option value="normal">Normal</option>
    <option value="low">Low</option>
  </select>
</span>

So when select control is clicked, display_criticality(); is triggered again and again.

Also one <option> should have "selected" attribute to display currently entered value.


Top
 Profile  
Reply with quote  
PostPosted: Thu Dec 02, 2010 8:45 pm 
Offline
Site Admin
User avatar

Joined: Mon Jun 07, 2004 11:48 am
Posts: 1935
Location: Brisbane, Australia
Of course !!!
Thanks, I'll look into it.

EDIT - fixed.

_________________
Support and Development hours available from Opmantek.
Please consider a purchase to help make Open-AudIT better for everyone.


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 10 posts ] 

All times are UTC + 10 hours


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group